Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes to server to allow admin panel to retrieve last activity instead of last logged in date #58

Merged

Conversation

Opaque02
Copy link
Contributor

The recent admin panel updates #54 accidentally are grabbing the last logged in date from the server instead of the last activity. This PR aims to fix it.

Here's an image of the live behaviour of the admin panel for a username:

image

vs after this PR:

image

As you can see, the "Last played" field now shows a different date. We can look at the db for this username:

image

As we can see, this is the right and expected result now

Below is an example of a new user who's made an account and logged in, but hasn't played yet. This is the current behaviour:

image

And here is the new behaviour:

image

As we can see, the last played field is null because they haven't played yet. This is their db record:

image

To test this PR, download it and try it out with the admin panel, comparing the values against the db for last activity instead of last logged in date

@patapancakes patapancakes merged commit c2af4a0 into pagefaultgames:master Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants